Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dlt-sortbytimestamp crash] Unreadable memory reference in my opinion #436

Closed
zj3t opened this issue Jan 24, 2023 · 5 comments · Fixed by #437
Closed

[dlt-sortbytimestamp crash] Unreadable memory reference in my opinion #436

zj3t opened this issue Jan 24, 2023 · 5 comments · Fixed by #437

Comments

@zj3t
Copy link

zj3t commented Jan 24, 2023

Hi COVESA Team!
Contact us to report vulnerabilities.

Summary

I done dlt-sortbytimestamp(+dlt-* binary) source code auditing .
And found that the exception handling was insufficient.
Since I'm not familiar with the dlt structure, I created a simple fuzzer to fuzzing the dlt-sortbytimestamp binary.

And I found a crash, and added ASAN (Address Sanitizer) to get additional information.

Bug Log

image

image

In my opinion, when the pointer is moved in the fseek() function, the crash occurs because it is moved to a place that cannot be referenced.
Or, Maybe it's caused by size tampering in the header of the DLT file.
But I don't know the detailed information of the DLT file.

image
[crash.dlt]

image
[output.dlt]

Looking at the output file, it was confirmed that it terminated in the middle.

Files

I will attach it.
covesa.zip

It may not be a big deal, it may be a bug (vulnerability), but I am reporting it because I hope you guys will fix it.
Thanks :)

michael-methner pushed a commit to michael-methner/dlt-daemon that referenced this issue Jan 27, 2023
Fixes COVESA#436

Signed-off-by: Michael Methner <mmethner@de.adit-jv.com>
@michael-methner
Copy link
Collaborator

Hello @zj3t , thanks for reporting the issue.

I have opened a PR.

@zj3t
Copy link
Author

zj3t commented Jan 27, 2023

Thanks @michael-methner :)
I'm glad!!
I think the fixes are perfect too.
Could you please tell me the CWE of the vulnerability?

Also can you allow me to get a CVE?

@michael-methner
Copy link
Collaborator

Hello @zj3t ,
i am not used to CWE, but I would say it is a: CWE-127: Buffer Under-read

For sure you can get a CVE.

@zj3t
Copy link
Author

zj3t commented Jan 30, 2023

Thanks @michael-methner :)

@stevebeattie
Copy link

FYI, this was assigned CVE-2023-36321.

(I did not assign the CVE, I'm just a messanger who noticed it while triaging recently published CVEs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants