fix usage of pthread_cond_timedwait #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pthread_cond_timedwait has to be called with a locked mutex using an unlocked mutex is undefined behaviour although it works on many platforms Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com> Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
alexmohr
commented
May 25, 2023
this commit makes sure that we do not wait for up to 10s if we missed the signal for the condition variable the first time Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
src/lib/dlt_user.c
Outdated
| @@ -3775,7 +3775,9 @@ void dlt_user_housekeeperthread_function(void *ptr) | |||
|
|
|||
| // signal dlt thread to be running | |||
| *dlt_housekeeper_running = true; | |||
| pthread_mutex_lock(&dlt_housekeeper_running_mutex); | |||
There was a problem hiding this comment.
As per my understading, the lock does not need to be hold while pthread_cond_signal() is called.
From posix specification:
"The pthread_cond_signal() or pthread_cond_broadcast() functions may be called by a thread whether or not it currently owns the mutex..."
Reference: https://pubs.opengroup.org/onlinepubs/7908799/xsh/pthread_cond_signal.html
I am fine with the rest of the changes.
There was a problem hiding this comment.
Hello @alexmohr ,
i just fixed my finding by myself. If you give me a 👍 , I'll merge the PR
There was a problem hiding this comment.
Thanks for fixing it! I did not find the time to do it myself :)
michael-methner
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pthread_cond_timedwait has to be called with a locked mutex using an unlocked mutex is undefined behaviour
although it works on many platforms
The program was tested solely for our own use cases, which might differ from yours.
Licensed under Mozilla Public License Version 2.0
Alexander Mohr, alexander.m.mohr@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, imprint