Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtest: Init submodule and update version #497

Merged
merged 1 commit into from
Jun 14, 2023
Merged

gtest: Init submodule and update version #497

merged 1 commit into from
Jun 14, 2023

Conversation

minminlittleshrimp
Copy link
Collaborator

@minminlittleshrimp minminlittleshrimp commented Jun 9, 2023 •
edited

  • Create a submodule for googletest in dlt
  • Update gtest version

@michael-methner
Copy link
Collaborator

Hello Minh,
the build job fails with following message:
CMake Error at CMakeLists.txt:337 (add_subdirectory):
-- Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY)
add_subdirectory given source "gtest-1.11.0" which is not an existing
directory.

Is there a call to "git submodule init" missing?

gtest: Init submodule and update version
7ed2751 
Signed-off-by: LUU QUANG MINH <Minh.LuuQuang@vn.bosch.com>
@minminlittleshrimp
Copy link
Collaborator Author

Rebase is done, please kindly merge.

@michael-methner
Copy link
Collaborator

Looks good to me. Thanks.

@michael-methner michael-methner merged commit 9285147 into COVESA:master Jun 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-methner michael-methner michael-methner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minminlittleshrimp @michael-methner