Prevent new daemon create on same machine #660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
duvanan13
commented
Jul 7, 2024
duvanan13
commented
- Only one daemon on the machine listening to fifo
- fifo will not be unlinked by the new daemon init
|
Hello @duvanan13 |
minminlittleshrimp
requested changes
Jul 8, 2024
CMakeLists.txt
Outdated
| @@ -94,7 +94,7 @@ option(WITH_DLT_FILE_LOGGING_SYSLOG_FALLBACK "Set to ON to enable fallback to sy | |||
| option(WITH_DLT_NETWORK_TRACE "Set to ON to enable network trace (if message queue is supported)" ON) | |||
| option(WITH_DLT_LOG_LEVEL_APP_CONFIG "Set to ON to enable default log levels based on application ids" OFF) | |||
|
|
|||
| set(DLT_IPC "FIFO" | |||
| set(DLT_IPC "UNIX_SOCKET" | |||
There was a problem hiding this comment.
By default the ipc is fifo, so please turn this flag inside git ci/cd script
tests/CMakeLists.txt
Outdated
| @@ -105,6 +104,10 @@ if(WITH_DLT_SHM_ENABLE) | |||
| list(APPEND TARGET_LIST gtest_dlt_shm) | |||
| endif() | |||
|
|
|||
| if(WITH_DLT_SHM_ENABLE AND DLT_IPC STREQUAL "UNIX_SOCKET") | |||
There was a problem hiding this comment.
Also turn shm on inside ci/cd script
tests/CMakeLists.txt
Outdated
| @@ -92,8 +92,7 @@ endforeach() | |||
| ################### | |||
| # DLT daemon tests | |||
| ################### | |||
| set(TARGET_LIST gtest_dlt_daemon_gateway | |||
There was a problem hiding this comment.
what is the purpose of removal here? what makes this test suite different with the other?
+ Only one daemon on the machine listening to fifo + fifo will not be unlinked by the new daemon init
duvanan13
force-pushed
the
prevent_new_daemon_create_on_same_machine
branch
from
e4d1f41
to
ad43b63
Compare
|
Close as duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.