-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Sorting by Lifecycle, startup time #307 #463
Conversation
I do not see any useful code in there wich solves any issue or provides any new functionality. |
Search for ISSUE_307 in src/mainwindow.cpp,, only one line of change, rest are for debugging |
@eaj40 I still do not know how this PR will solve the issue. Identifying lifecycles in a DLT file is a complex topic and cannot be solved by a single line.
The current implemented feature sorting by Timestamp is ignoring several lifecycles. |
What do you mean by Lifecycles
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows
…________________________________
From: Alexander Wenzel ***@***.***>
Sent: Tuesday, May 7, 2024 7:10:45 PM
To: COVESA/dlt-viewer ***@***.***>
Cc: eaj40 ***@***.***>; Mention ***@***.***>
Subject: Re: [COVESA/dlt-viewer] fix Sorting by Lifecycle, startup time #307 (PR #463)
@eaj40<https://github.com/eaj40> I still do not know how this PR will solve the issue. Identifying lifecycles in a DLT file is a complex topic and cannot be solved by a single line.
1. The Lifecycles of the DLT must be identified
2. Sorting by timestamp must be done based on the identified lifecycles
—
Reply to this email directly, view it on GitHub<#463 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADY65DHHBMGYENBY6LUZFDDZBDKV3AVCNFSM6AAAAABHD3O2VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGQZTOMRZGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Please see my comments
1. The Lifecycles of the DLT must be identified
[joe] resets when connected over TCP is identified
1. Sorting by timestamp must be done based on the identified lifecycles
[joe] Sorting by timestamp starts from 0, after reset. This is already supported feature
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows
…________________________________
From: Alexander Wenzel ***@***.***>
Sent: Tuesday, May 7, 2024 7:10:45 PM
To: COVESA/dlt-viewer ***@***.***>
Cc: eaj40 ***@***.***>; Mention ***@***.***>
Subject: Re: [COVESA/dlt-viewer] fix Sorting by Lifecycle, startup time #307 (PR #463)
@eaj40<https://github.com/eaj40> I still do not know how this PR will solve the issue. Identifying lifecycles in a DLT file is a complex topic and cannot be solved by a single line.
1. The Lifecycles of the DLT must be identified
2. Sorting by timestamp must be done based on the identified lifecycles
—
Reply to this email directly, view it on GitHub<#463 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADY65DHHBMGYENBY6LUZFDDZBDKV3AVCNFSM6AAAAABHD3O2VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGQZTOMRZGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Resets when connected over following, does it complete lifecycles |
fix #307