templates: Proposed VSC->IFEX changes #63
Conversation
|
If you want to take a look @erikbosch ... Otherwise it's nothing major, just making things "up to date" with the current. I have not heavily tested these templates, but they seem to generate output OK. (Protobuf is the one that is likely to get some more work on it soon, for the reason of supporting gRPC.) |
ifex/templates/dtdl/dtdl.md
Outdated
|
|
||
| FIXME: LINK | ||
|
|
||
| https://github.com/COVESA/vehicle_service_catalog#native-data-types) to [DTDL datatype](https://github.com/Azure/opendigitaltwins-dtdl/blob/master/DTDL/v2/dtdlv2.md#primitive-schemas). |
There was a problem hiding this comment.
Apparently the document has been updated, but if the code is based on the older spec, then maybe the link should not be updated? (not sure...)
There was a problem hiding this comment.
Oh I noticed, that's not the link that needs fixing, it is the "VSC" link. I'll set the PR to draft in the meantime.
| FIXME: LINK | ||
|
|
||
| [IFEX Structs](https://github.com/COVESA/vehicle_service_catalog#namespace-list-object-structs) can be represented as [DTDL Interface Object Schemas](https://github.com/Azure/opendigitaltwins-dtdl/blob/master/DTDL/v2/dtdlv2.md#interface-schemas). | ||
|
|
gunnarx
force-pushed
the
update_bosch_templates
branch
from
11f1b38
to
9edcbaf
Compare
|
Rebased and adding Interface node support. Not much tested yet. |
gunnarx
force-pushed
the
update_bosch_templates
branch
from
9edcbaf
to
021f313
Compare
| @@ -1,17 +1,17 @@ | |||
| {# Protobuf template #} | |||
| {# (C) 2022 Robert Bosch GmbH #} | |||
| // protobuf/gRPC definition generated using template: protobuf.tpl | |||
| // protobuf code generated by protobuf.tpl | |||
There was a problem hiding this comment.
"generated by AST_protobuf.tpl"?
gunnar-mb
force-pushed
the
update_bosch_templates
branch
from
021f313
to
bfd0f18
Compare
These are proposed changes to the descriptions (.md) and template files (.tpl) for DTDL, Protobuf, and SDS. The approach is to replace VSC with IFEX when talking about the language features and format, and to keep VSC when talking about the Vehicle Service Catalog as the source of the example files. In some cases when VSC or IFEX is superfluous, the word has simply been deleted for simplicity. The changes are trivial, so copyright statements (2022 Robert Bosch GmbH) do not need to be amended. Signed-off-by: Gunnar Andersson <gunnar@nospam@novaspring.eu>
gunnar-mb
force-pushed
the
update_bosch_templates
branch
from
bfd0f18
to
574de44
Compare
|
Rebased and fixed incorrect URLs / links, and the remark about AST_protobuf.tpl |
|
The updated template is still mostly untested but since there is no more new input/usage of DTDL right now, I'll merge it for now and if interest picks up later, then it can be further refined. |
These are proposed changes to the descriptions (.md) and template files (.tpl) for DTDL, Protobuf, and SDS.
The approach is to replace VSC with IFEX when talking about the language features and format, and to keep VSC when talking about the Vehicle Service Catalog as the source of the example files. In some cases when VSC or IFEX is superfluous, the word has simply been deleted for simplicity.
The changes are trivial, so copyright statements (2022 Robert Bosch GmbH) do not need to be amended.