Clarifying use of GNSS and Timestamp #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Clarifying that coordinates are based on WGS84 -Giving additional guidelines om timestamps, inspired by: https://www.w3.org/TR/NOTE-datetime https://raw.githack.com/w3c/automotive/gh-pages/spec/VISSv2_Core.html#timestamp
|
Decision 22/01/04: approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve two areas of VSS
GNSS
Previously we did not explicitly state that coordinates shall be based on WGS84, and the description on altitude was a bit ambiguous as it mentioned elevation. Now it clearly states that it is altitude over WGS84 reference ellipsoid.
(As I understand it altitude in WGS84 context refer to height over WGS84 reference ellipsoid, but elevation typically refers to height over WGS84 geoid (which varies depending on WGS84 revision used, e.g. EGM96, EGM2008)
Timestamp
We have recently started to specify that string formatted according to ISO 8601 shall be used for some signals. But ISO 8601 gives you a lot of alternatives and you do not even need to specify time zone, and then the string shall be interpreted as local time. We see no real reason to use anything else than UTC in signals, and we think it would be good to give additional details/recommendations in documentation.
The documentation proposal is reasonable aligned with what is specified by VISS and W3C:
https://www.w3.org/TR/NOTE-datetime
https://raw.githack.com/w3c/automotive/gh-pages/spec/VISSv2_Core.html#timestamp