Clarifying combination of instances and aggregate for branches #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theoretically a branch can have both instances and aggregate defined. This opens up two interpretation - that aggregate concerns the union of all instances or that aggregate concern individual instances.
danielwilms
approved these changes
Mar 15, 2022
|
decision to merge 2022-03-15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically a branch can have both instances and aggregate defined.
This opens up two interpretations - that aggregate concerns the union of all instances or that aggregate concern individual instances. This PR intends to clarify interpretation
Example:
The proposed interpretation is that aggregate here means that it makes sense to update color and fragrance for individual Wunderbaums together, but nothing prevents Wunderbaum1 from being updated separately from e.g. Wunderbaum3.