Add support for frunks #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
erikbosch
approved these changes
Mar 29, 2022
danielwilms
approved these changes
Mar 29, 2022
|
Decision to merge: 2022/04/12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will solve #391
As "frunk" seems colloquial, I went with instances for "Front" and "Rear", this is also aligned with wording in .
Tesla manual: "Front trunk" and "Rear trunk" ("vorderer Kofferraum", "hinterer Kofferraum" in German) https://www.tesla.com/ownersmanual/model3/en_us/
or KIA (EV6) says "Front trunk" https://gimmemanuals.com/owners/2022/03/2022-kia-ev6-owners-manual.pdf
Ford Mach E says "Kofferraum vorn" but "front luggage compartment"
https://www.fordservicecontent.com/Ford_Content/Catalog/owner_information/2021-Ford-Mustang-Mach-E-Owners-Manual-version-1_om_DE_09_2020.pdf
https://www.fordservicecontent.com/Ford_Content/Catalog/owner_information/2021-Ford-Mustang-Mach-E-Owners-Manual-Job-2_version-1_om_EN-US_05_2021.pdf
There deviations, e.g. Porsche: Bonnet and tailgate/rear lid https://www.taycanforum.com/forum/attachments/2020-porsche-taycan-drivers-owners-manual-pdf.3634/?hash=f1054d844b404c69dc097ac2448c927a , or Audi eTron is also in the "luggage compartment" compartment"
However I feel front/rear trunk captures the meaning of two storage areas well.
Independent from that, we might want to model "Bonnet", as in "cover for access to the engine", as we do not have that, but I would consider that another PR