Interior lights

[jdacoello]

feat: Improve the specification of interior lights to address issue #531 . Key aspects are listed below:

• SingleConfigurableLight.vspec defined for generic lights whose color, intensity, and state can be acted on.
• Changed previous name of AmbientLight to PerceivedAmbientLight. Previous definition was referring to the act of sensing the existing light in the ambient.
• AmbientLight redefined as actuator.
• Examples of configurable lights included: AmbientLight and Spotlight
• Add new concept for interactive lights, where an effect can be selected.

Signed-off by: Daniel Alvarez-Coello
daniel.alvarez-coello@bmwgroup.com

[erikbosch]

Meeting notes: Please review/comment. To be discussed at meeting Feb 21st.

[erikbosch]

PR based on old VSS version. I suggest rebasing on latest master to make sure that shown diff is up to date.

[jdacoello]

All comments were addressed, and the proposed specification was squashed into one commit.

Note: These changes target the next major release (i.e., V4.0)

[erikbosch]

Meeting notes: Awaiting left/right vs driver/passenger decision

[erikbosch]

Meeting notes:

• When Update instance description of Seat, Door, HVAC, Light and Mirror #538 is merged, update this PR to use the same terms for DriverSide/PassengerSide

[jdacoello]

Updated to use DriverSideand PassengerSide

[erikbosch]

There is a conflict that needs to be fixed

[erikbosch]

@jdacoello - would be great if you could update this PR to solve the conflicts

[erikbosch]

I think the primary reason why the PR build fails is that there have been a merge from master to your topic branch, rather than a rebase on master branch, causing some merge commits to appear that does not fulfill the sign-off requirement that we require nowadays. I believe the easiest way to solve it is to start from a fresh master branch, cherry pick the wanted changes or add them to a new commit so that there is only a single commit above master and the force push the branch to github. Then there are some minor problems with missing new lines or trailing blanks in the modified files that needs to be addressed.

[erikbosch]

Hi @jdacoello - For convenience I created a clean PR at #587 for both of your PRs, starting from a clean master. There the build succeeds. I think we can either take that one and use it for merge. What I did was taking the latest master and then replacing file content with those from your PRs, to get two clean and signed-off commits. The only additional change was to fix to linter errors depending on old code in the files.

[erikbosch]

Merged by #587