Removal of deprecated signals from VSS v3.1 #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two signals were listed as deprecated in VSS v3.1: Vehicle.TravelledDistance and Vehicle.Powertrain.FuelSystem.TimeSinceStart. Therefore, since the current (in-development) version is a major release (v4.0), these two signals should not appear. Signed-off-by: Nick Russell <79584907+nickrbb@users.noreply.github.com>
nickrbb
force-pushed
the
RemovalOfDeprecatedSignals
branch
from
b3e448d
to
c26d81f
Compare
|
Thanks for the PR. We have removal of deprecated signals as a step in the release preparations (see https://github.com/COVESA/vehicle_signal_specification/wiki/Release-Instructions-and-Checklist), but there is nothing that prevents the from being removed as soon as we have decided that next release on "master" will be a major release. |
erikbosch
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two signals were listed as deprecated in VSS v3.1: Vehicle.TravelledDistance and Vehicle.Powertrain.FuelSystem.TimeSinceStart. Therefore, since the current (in-development) version is a major release (v4.0), these two signals should not appear.