Add additional mirror signals #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Meeting notes:
|
|
Align with PR#265 for description of IsOpen for Door. (That is, use same approach regarding description of fully folded/fully opened and fully unfolded/fully closed. |
Inspired by the Android signals MIRROR_LOCK and MIRROR_FOLD Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
|
Meeting notes: OK to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the Android signals MIRROR_LOCK and MIRROR_FOLD.
Lock Signal
This signal might reflect the quite common design vehicle where you have common up/down/left/right buttons and a separate switch to decide if it shall affect left/right/none mirror. I.e. in "none" both left and right are locked
Fold signal
It can be discussed if we rather would need a percent-signal, where 100% either means fully folded or fully unfolded. Might be useful if you want to monitor progress or control speed.