Initialize the routing running state #655
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The routing manager running state appears uninitialised, which can (and has) resulting in routingmanagerd starting up in a suspend state.
|
General question on this and #653: How is this not caught by compiler warnings or static-analysis evaluation? |
A lot of #560 was addresses the results from cppcheck, but either I missed this, or I mainly focused on shadowing, or maybe I first ran this on 3.1.20 which didn't have this member. But yeah, I was also wondering why I didn't notice this last time I ran static-analysis. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routing manager running state appears uninitialised, which can (and has) resulting in routingmanagerd starting up in a suspend state.