Use TCP keepalive to detect broken sockets #681
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsomeip does not enforce a single socket between endpoints; it does not actively close an existing socket after a new one is established. It is possible that: - socket is established from nodeA to nodeB - ethernet gets unplugged - nodeA tries to transmit, times out, closes the socket - ethernet is reconnected - nodeA establishes a new socket to node B nodeB never received an RST while the cable was unplugged, still thinks the old socket is established, and effectively "leaks" until TCP keepalive detects the break. At default values this takes 2 hr 10 min. This can be mitigated by reducing the keepalive settings. The implementation of TCP keepalive is different between OS: - Linux can configure all 3 settings on a per-socket basis - QNX can configure 1 setting per-socket and 2 settings globally QNX would need to set the global values using sysctl, perhaps at startup.
|
@joeyoravec is this ready to review or are you still working on this? |
I've left this in draft so it's clear that this is not ready for merge. Yes this "works" and is worth reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #674
vsomeip does not enforce a single socket between endpoints; it does not actively close an existing socket after a new one is established.
It is possible that:
nodeB never received an RST while the cable was unplugged, still thinks the old socket is established, and effectively "leaks" until TCP keepalive detects the break. At default values this takes 2 hr 10 min. This can be mitigated by reducing the keepalive settings.
The implementation of TCP keepalive is different between OS:
QNX would need to set the global values using sysctl, perhaps at startup.