Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and expose settings for SD find debounce as config options #716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tommyhaley
Copy link

In this change a configurable initial debounce
interval for SD find as well as a configurable
number of initial debounces are introduced. This
implies that services requested in the initial
debounce phase will at most wait for an initial
debounce interval before being included in a SD
find debounce. After the initial debounce phase is completed, all subsequent SD find debounces will
use the default debounce interval.

Added and exposed options:

  • find_initial_debounce_reps
  • find_initial_debounce_time

Exposed option:

  • find_debounce_time

In this change a configurable initial debounce
interval for SD find as well as a configurable
number of initial debounces are introduced. This
implies that services requested in the initial
debounce phase will at most wait for an initial
debounce interval before being included in a SD
find debounce. After the initial debounce phase is
completed, all subsequent SD find debounces will
use the default debounce interval.

Added and exposed options:
* find_initial_debounce_reps
* find_initial_debounce_time

Exposed option:
* find_debounce_time
@tommyhaley tommyhaley marked this pull request as ready for review June 5, 2024 12:05
@tommyhaley
Copy link
Author

@GenivivSOMEIPmaintainer How to get attention from maintainer/reviewer?

…ons"

Changed find_initial_debounce_reps from uint32_t to uint8_t
Simplified propsed logic change in service_discovery_impl

This commit should be squashed into previous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant