Fixing limitation for allowed for ddsidl #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess 502 refers to COVESA/vehicle_signal_specification#502 Can you check if this looks reasonable @zam1kor ? |
erikbosch
commented
Jan 10, 2023
tests/vspec/test_allowed/test.vspec
Outdated
| description: An int | ||
|
|
||
| A.Float: | ||
| datatype: uint16 |
|
Meeting notes: Erik to fix error, please review until next week. Decision to merge next week |
Previously ddsidl could not handle allowed for float/int as it expected string values. Now it will ignore allowed for float/int and give a warning
erikbosch
force-pushed
the
erikbosch/erik_allowed
branch
from
3e7a8d0
to
b037b48
Compare
|
The error found has been fixed. |
SebastianSchildt
approved these changes
Jan 23, 2023
|
Meeting decision: merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ddsidl could not handle allowed for float/int as it expected string values.
Now it will ignore allowed for float/int and give a warning.
Fixes #502