Generalize cleanup solution #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I see as well extension for the deployment configuration. I guess that was needed in order to test updates of cleanup improvements. |
Yes, the problem that some metadata was kept was detected when we experimented with adding deployment metadata. The metadata in the test files shall just be seen as an example on users can add metadata and how the tool will handle it. |
|
Meeting notes: Please review until next week |
The previous limitation to only clean branches will give problems when supporting structs, but also if using structured extended attributes. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
erikbosch
force-pushed
the
erikbosch/erik_cleanup
branch
from
8642714
to
c63e3bc
Compare
|
Meeting decision: Merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous limitation to only clean branches will give problems when supporting structs, but also if using structured extended attributes.
The problem can be seen by running the included overlay example without the fix, then some unwanted metadata will be printed.