Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test commit without signoff #290

Closed
wants to merge 1 commit into from
Closed

Conversation

erikbosch
Copy link
Collaborator

@erikbosch erikbosch commented May 30, 2023

This is a test of using the DCO github app rather than an action (as today). Not intended for merge - it does not contain any reasonable changes! It is just to test DCO that has been configured for this repository.

Potential benefits:

  • Could possibly be activated for all COVESA Github repos (but that is not for us to decide), or just for "ours"
  • Easier to maintain than separate actions on all repos
  • The "old" DCO action does not seem to be that frequently updated - may give problems in the future as it uses Node.js 12

Please check build actions and compare reports for "old" and "new" DCO check. If we are "happy" with using DCO App we can later remove the old check and activate the DCO App also for VSS repo

image

@erikbosch
Copy link
Collaborator Author

No objections to using DCO action, let use it for a while before removing DCO action

@erikbosch erikbosch closed this Jun 1, 2023
@erikbosch erikbosch deleted the erik_tmp branch September 29, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant