ivi-controller.c: Defer ID allocation to desktop_surface_configured #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with weston developers here:
https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1475
The ID allocation must happen in the the first emission of the
desktop_surface_configured signal, not at surface creation time.
This is also incidentally reflected and affirmed by this slide deck:
https://wiki.automotivelinux.org/_media/agl-distro/agl_amm_xdg_support_a04.pdf
This fixes the IVI controller handling client applications, like GTK+
applications which will set the app-id and window title after triggering
the underlying surface creation (by calling set_parent(nil)) but before
triggering the desktop_surface_configured event (by calling wl_surface_commit()).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with weston developers here:
The ID allocation must happen in the the first emission of the desktop_surface_configured signal, not at surface creation time.
This is also incidentally reflected and affirmed by this slide deck:
https://wiki.automotivelinux.org/_media/agl-distro/agl_amm_xdg_support_a04.pdf
This fixes the IVI controller handling client applications, like GTK+ applications which will set the app-id and window title after triggering the underlying surface creation (by calling set_parent(nil)) but before triggering the desktop_surface_configured event (by calling wl_surface_commit()).