Education model #148
Merged
Education model #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeMoosery
requested changes
Mar 22, 2020
There was a problem hiding this comment.
This looks good on the backend side of things! Just two quick things.
- It looks like
.DS_Storeis still popping up - we added that to the.gitignoreright? Might be worth investigating here. - Since I'm not the main voice for coming up with the fields, I'll defer to @ngiangre to make sure these are the fields we want in this model.
|
the fields look good to me |
|
If there are any .DS_Store files in those files where I added/modified the .gitignore file, they will still be there. They would have to be removed. The .gitignore only prevents them from being added again. |
|
Ah okay, makes sense. Merging now! |
SomeMoosery
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the education model based on the education tab in the Data Model/Education spreadsheet. https://docs.google.com/spreadsheets/d/1Ji0sxIqFI49EZb7Mz4F0nkSBn1JSNMXiKjFAzJC2Jso/edit?usp=sharing