Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart annotations - manage in Contentful, add indicator #1172

Merged
merged 7 commits into from
Jul 6, 2020

Conversation

kevee
Copy link
Member

@kevee kevee commented Jul 2, 2020

  • Uses a new Event type in Contentful to manage chart annotations
  • Adds a Notes indicator to a chart if an annotation exists

Pre merge steps

  • Move content over to master environment in Contentful
  • Change environment in this branch

@kevee kevee requested a review from goleary July 2, 2020 15:36
@netlify
Copy link

netlify bot commented Jul 2, 2020

This is a preview version of the site.

Built with commit 0114210

https://deploy-preview-1172--upbeat-lovelace-3e9fff.netlify.app

@calibre-analytics
Copy link

calibre-analytics bot commented Jul 2, 2020

Comparing Chart annotations - manage in Contentful, add indicator Snapshot #7 to median since last deploy of The COVID Tracking Project.

Performance FCP? TTI?
Overall
Median across all pages and test profiles
72
from 74
840ms
from 593ms
5.87s
from 5.21s
Chrome Desktop
Chrome • Cable
74
from 78
582ms
from 316ms
2.97s
from 2.5s
MotoG4, 3G connection
Motorola Moto G4 • Regular 3G
69
from 72
994ms
no change
8.14s
from 8.05s

2 pages tested

 Home

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
MotoG4, 3G connection
144 Bytes
from 115 KB
Total JSON size in bytes
Chrome Desktop
117 KB
from 280 KB
Total Page size in bytes
Chrome Desktop
1.48 MB
from 1.64 MB
 Data page

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Largest Contentful Paint
MotoG4, 3G connection
3.45s
from 1.35s
First Meaningful Paint
MotoG4, 3G connection
3.45s
from 1.35s
First Contentful Paint
Chrome Desktop
858ms
from 341ms
Largest Contentful Paint
Chrome Desktop
1.13s
from 479ms
First Meaningful Paint
Chrome Desktop
1.13s
from 541ms

3 other significant changes: Speed Index on Chrome Desktop, Speed Index on MotoG4, 3G connection, Total JSON size in bytes on Chrome Desktop

Calibre: Site dashboard | View this PR | Edit settings

@kevee kevee marked this pull request as ready for review July 6, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant