Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Provide compatibility method for Extbase repositories #23

Merged
merged 1 commit into from Nov 12, 2021

Conversation

eliashaeussler
Copy link
Member

@eliashaeussler eliashaeussler commented Nov 12, 2021

This PR provides a new compatibility method in AbstractDataProcessor. It can be used to reset the global ConfigurationManager that is responsible to e.g. resolve the storage PIDs defined in the current content element.

In order to use the new method, just call the initializeConfigurationManager() method in your data processor. Note: This method is only available in case your data processor extends the AbstractDataProcessor class.

 # Classes/DataProcessing/HeaderProcessor.php

 namespace Vendor\Extension\DataProcessing;

 use Fr\Typo3Handlebars\DataProcessing\AbstractDataProcessor;

 class HeaderProcessor extends AbstractDataProcessor
 {
     protected function render(): string
     {
+        $this->initializeConfigurationManager();
         $data = $this->provider->get($this->cObj->data);
         return $this->presenter->present($data);
     }
 }

@eliashaeussler eliashaeussler added the enhancement New feature or request label Nov 12, 2021
@eliashaeussler eliashaeussler self-assigned this Nov 12, 2021
@eliashaeussler eliashaeussler force-pushed the feature/support-extbase-repositories branch from 38faee4 to e037a6d Compare November 12, 2021 14:44
@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@eliashaeussler eliashaeussler force-pushed the feature/support-extbase-repositories branch from e037a6d to f578a56 Compare November 12, 2021 14:46
@eliashaeussler eliashaeussler force-pushed the feature/support-extbase-repositories branch from f578a56 to f710ff0 Compare November 12, 2021 14:57
@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@eliashaeussler eliashaeussler merged commit eb8fcc1 into develop Nov 12, 2021
@eliashaeussler eliashaeussler deleted the feature/support-extbase-repositories branch November 12, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant