Merge pull request #115 from CPS-IT/task/drop-identifier

[!!!][TASK] Drop deprecated `identifier` property
CPS-IT · Feb 22, 2023 · 4329a0d · 4329a0d
2 parents b7ff936 + ed6f33f
commit 4329a0d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/docs/development/configuration.md b/docs/development/configuration.md
@@ -135,8 +135,6 @@ for an overview of supported filenames.
 
 Each config file should at least contain the following properties:
 
-* **`identifier`** describes the project type. It is used internally to handle
-  project generation while processing the required build steps.
 * **`name`** is kind of a label for the configured project type. It is mainly
   used for communication with the user, keeping the actual project type internal.
 * **`steps`** defines a list of necessary build steps. Those steps are processed
@@ -155,7 +153,6 @@ Example:
 :linenos:
 :caption: config.yaml
 
-identifier: my-fancy-project
 name: My fancy project
 
 steps:
@@ -225,7 +222,6 @@ Each configured property in the config file is now accessible from the
 
 | Property     | Accessor                   | Type                                                                                                                                           |
 |--------------|----------------------------|------------------------------------------------------------------------------------------------------------------------------------------------|
-| `identifier` | `$config->getIdentifier()` | `string`                                                                                                                                       |
 | `name`       | `$config->getName()`       | `string`                                                                                                                                       |
 | `steps`      | `$config->getSteps()`      | [`list<Builder\Config\ValueObject\Step>`](https://github.com/CPS-IT/project-builder/blob/main/src/Builder/Config/ValueObject/Step.php)         |
 | `properties` | `$config->getProperties()` | [`list<Builder\Config\ValueObject\Property>`](https://github.com/CPS-IT/project-builder/blob/main/src/Builder/Config/ValueObject/Property.php) |

diff --git a/resources/config.schema.json b/resources/config.schema.json
@@ -3,12 +3,6 @@
 	"type": "object",
 	"title": "Project builder template configuration",
 	"properties": {
-		"identifier": {
-			"type": "string",
-			"title": "Project template identifier",
-			"description": "No longer needed, templates are now identified by their Composer package name.",
-			"deprecated": true
-		},
 		"name": {
 			"type": "string",
 			"title": "Project template name",