Merge pull request #55 from CPS-IT/feature/phpstan-type-coverage

[FEATURE] Measure type coverage within PHPStan
CPS-IT · Dec 8, 2022 · 45693c3 · 45693c3
2 parents c871a66 + ef8fc5a
commit 45693c3
Show file tree

Hide file tree

Showing 4 changed files with 224 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -52,7 +52,8 @@
 		"phpstan/phpstan-webmozart-assert": "^1.2",
 		"phpunit/phpunit": "^9.5.5",
 		"rector/rector": "^0.14.8",
-		"seld/jsonlint": "^1.9"
+		"seld/jsonlint": "^1.9",
+		"symplify/phpstan-rules": "^11.1"
 	},
 	"autoload": {
 		"psr-4": {

diff --git a/composer.lock b/composer.lock
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,5 +1,6 @@
 includes:
     - .build/vendor/phpstan/phpstan/conf/bleedingEdge.neon
+
 parameters:
     level: max
     paths:
@@ -11,3 +12,29 @@ parameters:
         - tests/bootstrap.php
     symfony:
         containerXmlPath: var/cache/test-container.xml
+
+services:
+    -
+        class: Symplify\PHPStanRules\Rules\Explicit\PropertyTypeDeclarationSeaLevelRule
+        tags: [phpstan.rules.rule]
+        arguments:
+            minimalLevel: 0.99
+    -
+        class: Symplify\PHPStanRules\Rules\Explicit\ParamTypeDeclarationSeaLevelRule
+        tags: [phpstan.rules.rule]
+        arguments:
+            minimalLevel: 0.99
+    -
+        class: Symplify\PHPStanRules\Rules\Explicit\ReturnTypeDeclarationSeaLevelRule
+        tags: [phpstan.rules.rule]
+        arguments:
+            minimalLevel: 0.99
+    -
+        class: Symplify\PHPStanRules\Collector\FunctionLike\ParamTypeSeaLevelCollector
+        tags: [phpstan.collector]
+    -
+        class: Symplify\PHPStanRules\Collector\FunctionLike\ReturnTypeSeaLevelCollector
+        tags: [phpstan.collector]
+    -
+        class: Symplify\PHPStanRules\Collector\ClassLike\PropertyTypeSeaLevelCollector
+        tags: [phpstan.collector]
diff --git a/src/IO/InputReader.php b/src/IO/InputReader.php
@@ -125,7 +125,7 @@ public function choices(
      *
      * @return TYes|TNo
      */
-    public function ask(string $question, $yesValue = true, $noValue = false, bool $default = true)
+    public function ask(string $question, mixed $yesValue = true, mixed $noValue = false, bool $default = true): mixed
     {
         $label = Messenger::decorateLabel($question, $default ? 'Y' : 'N', true, [$default ? 'n' : 'y']);