Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][TASK] Lock provider type in template artifact #95

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

eliashaeussler
Copy link
Member

@eliashaeussler eliashaeussler commented Feb 1, 2023

Restoring a build artifact cannot be done properly if the original template provider cannot be determined. Hence, we now use the provider type instead of its name.

This is breaking change as it results in a new build artifact version (16794971371688738958).

@eliashaeussler eliashaeussler added the bug Something isn't working label Feb 1, 2023
@eliashaeussler eliashaeussler self-assigned this Feb 1, 2023
@codeclimate
Copy link

codeclimate bot commented Feb 1, 2023

Code Climate has analyzed commit 93581d5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.7% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #95 (cd11f37) into 3.x (5019fc6) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.x      #95      +/-   ##
============================================
+ Coverage     98.20%   98.29%   +0.09%     
- Complexity      770      776       +6     
============================================
  Files           111      112       +1     
  Lines          2445     2462      +17     
============================================
+ Hits           2401     2420      +19     
+ Misses           44       42       -2     
Impacted Files Coverage Δ
src/Builder/Artifact/TemplateArtifact.php 100.00% <ø> (ø)
...Builder/Artifact/Migration/Migration1688738958.php 100.00% <100.00%> (ø)
src/Builder/ArtifactGenerator.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eliashaeussler eliashaeussler requested review from mteu and removed request for mteu February 1, 2023 10:01
@eliashaeussler eliashaeussler marked this pull request as draft February 1, 2023 10:05
@mteu mteu force-pushed the fix/artifact-provider-class branch from eee08f2 to acd67a9 Compare February 8, 2023 11:31
@mteu
Copy link
Collaborator

mteu commented Feb 8, 2023

This seems ready for shipment. What could possibly be open here?

@eliashaeussler
Copy link
Member Author

This seems ready for shipment. What could possibly be open here?

@mteu Once #96 is merged, I'll change this PR to lock the provider type instead of class. That's a little bit more straightforward in terms of artifact reconstitution.

@mteu
Copy link
Collaborator

mteu commented Feb 8, 2023

This seems ready for shipment. What could possibly be open here?

@mteu Once #96 is merged, I'll change this PR to lock the provider type instead of class. That's a little bit more straightforward in terms of artifact reconstitution.

Makes sense, thank you.

@eliashaeussler eliashaeussler added this to the v2.0.0 milestone Feb 22, 2023
@eliashaeussler eliashaeussler changed the title [BUGFIX] Lock provider class in template artifact [!!!][TASK] Lock provider type in template artifact Feb 23, 2023
@eliashaeussler eliashaeussler added breaking This introduces a breaking change maintenance Code base is being maintained and removed bug Something isn't working labels Feb 23, 2023
@eliashaeussler eliashaeussler modified the milestones: v2.0.0, v3.0.0 Mar 24, 2023
@eliashaeussler eliashaeussler changed the base branch from develop to 3.x July 7, 2023 13:45
@eliashaeussler eliashaeussler marked this pull request as ready for review July 8, 2023 18:30
@eliashaeussler eliashaeussler requested a review from mteu July 8, 2023 18:30
@mteu
Copy link
Collaborator

mteu commented Jul 10, 2023

@eliashaeussler 👍

Wanna wait for codeclimate or fire at once?

@eliashaeussler eliashaeussler merged commit d4c8aa5 into 3.x Jul 10, 2023
25 checks passed
@eliashaeussler eliashaeussler deleted the fix/artifact-provider-class branch July 10, 2023 08:51
@mteu
Copy link
Collaborator

mteu commented Jul 10, 2023

👏

@eliashaeussler
Copy link
Member Author

@eliashaeussler 👍

Wanna wait for codeclimate or fire at once?

Thanks for your approval. I'm too tired to wait for all those obviously unstable CGL tools.

@mteu
Copy link
Collaborator

mteu commented Jul 10, 2023

Thanks for your approval. I'm too tired to wait for all those obviously unstable CGL tools.

I feel you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This introduces a breaking change maintenance Code base is being maintained
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants