Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add license option to steps #12

Closed
wants to merge 1 commit into from

Conversation

mteu
Copy link
Collaborator

@mteu mteu commented Dec 8, 2022

What changed?

This PR address the feature request from #11 where the GPL license will be selectable and the corresponding legal document will be created upon project creation.

Alternatives?

Instead of listing all potential licenses one might consider outsourcing those files to either sharedFiles or better yet to self-sufficient package. However, in this very case – since we're offering a TYPO3 template – GPL v2/v3 should be most appropriate.

Notice!

In order for this feature being able to be used CPS-IT/project-builder#54 needs to be approved and released. Hence, this PR is kept as a draft until said feature is released.

@mteu mteu added the enhancement New feature or request label Dec 8, 2022
@mteu mteu linked an issue Dec 8, 2022 that may be closed by this pull request
@mteu mteu marked this pull request as draft December 8, 2022 13:37
@mteu mteu changed the title Draft: [FEATURE] add license option to steps [FEATURE] add license option to steps Dec 8, 2022
@mteu mteu changed the base branch from main to develop December 8, 2022 13:53
@mteu mteu marked this pull request as ready for review December 16, 2022 16:55
Copy link
Member

@eliashaeussler eliashaeussler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mteu, thanks for your feature proposal.

Generally, actively selecting a license seems like a very good idea to me. However, in context of TYPO3 projects I see two main issues:

  1. TYPO3 itself is licensed under GPL 2.0 and requires extensions to be licensed under GPL 2.0 as well (see TYPO3's Open Source Licenses). Even if it's stated that this affects TYPO3 extensions only, I'd highly recommend to also apply these rules to TYPO3 projects as well and to not mix up licenses when working in TYPO3 context.
  2. I assume that most TYPO3 projects may never be public, thus being normally developed as a proprietary product. I'd say, additionally defining a license for such cases is a very uncommon way. However, if we decide to include licenses in the template, we should at least provide an option to select a proprietary license.

As a result, I'd vote for not introducing licenses for the TYPO3 project template, as it does not perfectly fit for this use case. When talking about templates for e.g. TYPO3 extensions or generic Composer packages, I'd instantly vote for adding this additional step.

@mteu mteu closed this Dec 22, 2022
@mteu
Copy link
Collaborator Author

mteu commented Dec 22, 2022

You're perfectly right. Although my understanding of GPL-2.0-or-later differs from yours, let's not overcomplicate things here.

@mteu mteu deleted the feature/add-license-option-to-steps branch December 22, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add license option to steps
2 participants