AWS Deployment improvements #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| metavar='DATA_ABSTRACTION_LAYER', action='store', | ||
| help="Deploys containers on all running servers. Valid abstraction layers " \ | ||
| "are DFS and S3") | ||
| parser.add_argument('-w', '--worker_limit', type=int, action='store', default=0) |
There was a problem hiding this comment.
This is inconsistent with workers-only and deployment-credentials which use -, not _
aws/aws.py
Outdated
| help="Deployed workers will connect to this master instead of deploying " \ | ||
| "a new one on AWS.") | ||
| parser.add_argument('--workers-only', action='store_true', default=False, | ||
| help="When this flag is set we will only create and deploy to workers" ) |
There was a problem hiding this comment.
Why is workers only needed when we have master-ip?
There was a problem hiding this comment.
When creating new instances we don't need a master IP. So if you wanted to create 20 new instances without providing a master yet you would have to run aws.py -c 20 -m <random-unused-data>. I felt that it was neater to have it as aws.py -c 20 --workers-only, but i'm fine with removing it if you disagree.
RyanConnell
force-pushed
the
feature/aws-deployment-improvements
branch
from
4b5d47b
to
9f782d1
Compare
ConorGriffin37
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple improvements and changes to the AWS deployment script.
Added the following flags: