Implement SecondaryMap for HashSet #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
approved these changes
Jun 6, 2023
Comment on lines
+284
to
+288
| if HashSet::contains(self, &key) { | ||
| &true | ||
| } else { | ||
| &false | ||
| } |
There was a problem hiding this comment.
Suggested change
| if HashSet::contains(self, &key) { | |
| &true | |
| } else { | |
| &false | |
| } | |
| &HashSet::contains(self, &key) |
There was a problem hiding this comment.
Annoyingly we cannot do that, because the return value of HashSet::contains(self, &key) is a local variable, where true and false can be statically defined :/
src/secondary.rs
Outdated
| } | ||
|
|
||
| #[inline] | ||
| fn resize(&mut self, _new_len: usize) {} |
There was a problem hiding this comment.
not sure I follow why this is empty
There was a problem hiding this comment.
The method was meant to truncate the linear vecs in Unmanaged map and BitVec, but that doesn't make sense on sparse unordered containers.
It should probably be removed from the trait (it's never used).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #60. Partially implements #55.
The HashMap is a lot more tricky due to having to return references to a generic default value.