Use github-hosted runners for MacOS arm64 builds #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
changed the title
cqc-melf
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still using the self-hosted arm64 mac for Linux/arm64 builds (using docker), as I haven't yet managed to get docker running on the github-hosted VMs. (Will keep trying.)
One minor annoyance is that
actions/setup-pythoncan't install Python 3.9 on the arm64 Mac VMs ( actions/setup-python#696 ), so I use brew to install Python 3.9 instead.Release workflow tested here: https://github.com/CQCL/tket/actions/runs/6404838599 .
(I'll need to modify the names of the "required" checks after this merge: three showing as "required" don't exist anymore.)