Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Order files by last-modified when selecting what to print #267

Open
BloodyRain2k opened this issue Jul 26, 2021 · 4 comments
Open

[FR] Order files by last-modified when selecting what to print #267

BloodyRain2k opened this issue Jul 26, 2021 · 4 comments
Labels
t:enhancement New feature or request

Comments

@BloodyRain2k
Copy link

BloodyRain2k commented Jul 26, 2021

Describe the feature you want

The files being ordered by last-modified when selecting what to print, is pretty much the only thing I really miss from the Creality firmware.

It's really bothersome when you're keeping all old prints on the card, just because why not, and then the new ones end up at the bottom just because they start with a late letter.

@Sebazzz Sebazzz added the t:enhancement New feature or request label Nov 28, 2021
@trevorade
Copy link

I'd be willing to try to help out with a PR but I'm unfamiliar with the code base and I have no idea where the file select UI even is...

Any pointers on where to look to see about implementing this behavior?

@Sebazzz
Copy link
Collaborator

Sebazzz commented Jan 21, 2022

Any pointers on where to look to see about implementing this behavior?

It would normally be simply be a flag in Configuration_adv.h, in regard to SD card file sorting. However, it is more complex than that. The files are loaded into the FileList structure from ui_api.cpp. Last time I checked, it messed up things like directory browsing in the UI.

@BloodyRain2k
Copy link
Author

Another thing I noticed only recently: while printing, the UI is scrolling through long filenames like a "news ticker", but during selection of said file, it does not.
Not even in the confirmation dialog.

I can assume that such scrolling isn't that easy to do on a micro controller vs a full OS app, but if it can do so during printing, it should do so too when the confirmation is asking if this is the file the user wants to print.

@Sebazzz
Copy link
Collaborator

Sebazzz commented Apr 2, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants