Resolving #178 #193
Merged
Resolving #178 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sritejakv
commented
Nov 4, 2019
sritejakv
commented
- Added a boomerang query to find the points to information of the call site parameters. For each of the array parameters, its constants are found by traversing through the jimple method body.
- Added a headless test for SSLParameters.
kruegers
requested changes
Nov 5, 2019
| super(c); | ||
| this.icfg = icfg; |
There was a problem hiding this comment.
Please do not drag icfg, Bommerang and all that into the constraint solver. The field parsAndVals (defined in line 78) contains the values of all objects. The extraction happens someplace else. Rather move the triggering of Boomerang to retrieve the array values.
There was a problem hiding this comment.
Removed boomerang and icfg and changed the implementation using parsAndVals.
| */ | ||
| private BackwardBoomerangResults<NoWeight> getBoomerangResults(Value sootValue, CallSiteWithParamIndex callSite, | ||
| ExtractedValue allocSite, ObservableICFG<Unit, SootMethod> dynICFG){ | ||
| Boomerang boomerang = new Boomerang(new CogniCryptIntAndStringBoomerangOptions()) { |
There was a problem hiding this comment.
Attempt to minimize the number of Boomerang instance over the whole analysis. By moving this code to where the extraction takes place as suggested above, you should be able to get rid of this instance.
There was a problem hiding this comment.
Removed the boomerang call as it is not required.
- Removed the usage of boomerang and icfg. - Array values are fetched using parsAndVals variable.
- Added java doc
kruegers
approved these changes
Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.