Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some BCUsagePatternTests & edited existing BCHeadlessTests to verify OR-ing predicates #214

Merged
merged 6 commits into from
Feb 18, 2020
Merged

Added some BCUsagePatternTests & edited existing BCHeadlessTests to verify OR-ing predicates #214

merged 6 commits into from
Feb 18, 2020

Conversation

rakshitkr
Copy link
Contributor

No description provided.

@rakshitkr rakshitkr mentioned this pull request Feb 3, 2020
Open
@rakshitkr
Added another test for RSAEngine
b9f113b
@rakshitkr
Changed the location of hasEnsuredPredicate calls
c9be4e0 
Moved the location of hasEnsuredPredicate calls next to their ensured objects. This is done because next immediate method call from ORDER section performed on the object is negating its ensured predicates in UsagePatternTestingFramework
@rakshitkr
Updated the error counts for rules-with-OR-predicates
cdd9336 
This commit removes some of the error counts related to CryptSL/issue-11
@rakshitkr
Added false negatives as per issue #216
16fc5b6
@rakshitkr rakshitkr changed the title Added tests for ORing 2 & 3 predicates Added some BCUsagePatternTests & edited existing BCHeadlessTests to verify OR-ing predicates Feb 8, 2020
@rakshitkr
Added more false negatives as per issue #216
50e0684 
This commit updates the error counts of testBCEllipticCurveExamples headless tests to handle false negatives related to CryptSL/issue-11
@rakshitkr
Copy link
Contributor Author

rakshitkr commented Feb 8, 2020 •
edited

@kruegers I've updated the BC headless testcases to handle false negatives (FN) related to issue #216. You can merge these changes currently so that you can merge the other commits to CryptoAnalysis. Once I fix the issue with OR operator then we can change all the FNs to true positives

@rakshitkr
Copy link
Contributor Author

Merge this PR before merging the following pull request

@kruegers kruegers merged commit 98eccd4 into develop Feb 18, 2020
@rakshitkr rakshitkr deleted the bc-usagepattern-or-tests branch May 28, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruegers kruegers kruegers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rakshitkr @kruegers