Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name collision of downloaded products #66

Closed
sbrunato opened this issue Oct 31, 2018 · 7 comments
Closed

Name collision of downloaded products #66

sbrunato opened this issue Oct 31, 2018 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@sbrunato
Copy link
Collaborator

Original report by Stéphan AIME (Bitbucket: Fifan31, GitHub: Fifan31).


So far, title of product is used to name a downloaded product. But when products share almost the same extend (stereo products for instance), they may have the same title that lead to a name collision.

The 1st product is downloaded (and unzipped), the second is downloaded overriding the first one and it is not unzipped as the name already exists.

Proposed solution: add a unique suffix (uuid?) to product title

@sbrunato
Copy link
Collaborator Author

sbrunato commented Nov 5, 2018

Original changes by Oyono (Bitbucket: aoyono, GitHub: aoyono).


set version to "0.7.0"; set milestone to "0.7.0"

@sbrunato
Copy link
Collaborator Author

sbrunato commented Nov 6, 2018

Original comment by Stéphan AIME (Bitbucket: Fifan31, GitHub: Fifan31).


A pull request has been submitted to fix the issue

@sbrunato
Copy link
Collaborator Author

Original changes by Oyono (Bitbucket: aoyono, GitHub: aoyono).


changed version from "0.7.0" to "0.7.1"; changed milestone from "0.7.0" to "0.7.1"

@sbrunato
Copy link
Collaborator Author

Original changes by Oyono (Bitbucket: aoyono, GitHub: aoyono).


set assignee_account_id to "557058:ebae5ae5-74ea-4794-bfb3-34af5b131d00"; set assignee to "aoyono"

@sbrunato
Copy link
Collaborator Author

Original comment by Oyono (Bitbucket: aoyono, GitHub: aoyono).


Fix #66

Concatenate 'title' and 'id' of a product to build it's name.
Add a 'sanitize' method to remove spaces, punctuation,.... in product name

→ <<cset 0a280d156e57>>

@sbrunato
Copy link
Collaborator Author

Original comment by Oyono (Bitbucket: aoyono, GitHub: aoyono).


Merge branch 'i66-name_collision' of https://bitbucket.org/Fifan31/eodag into wip-towards-0.7.1

Fix #66

→ <<cset 8d640dfa4ab2>>

@sbrunato
Copy link
Collaborator Author

Original changes by Oyono (Bitbucket: aoyono, GitHub: aoyono).


changed state from "new" to "resolved"

@sbrunato sbrunato added major bug Something isn't working labels Jun 18, 2020
@sbrunato sbrunato added this to the 0.7.1 milestone Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant