Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[plugins/cds]: extract date from _dc_qs only if it exists #1000

Merged
merged 1 commit into from Jan 25, 2024

Conversation

alambare-csgroup
Copy link
Collaborator

Do not try to extract date if it does not exist in query params

Copy link
Contributor

Test Results

    4 files  ±0      4 suites  ±0   4m 17s ⏱️ +3s
  452 tests ±0    449 ✅ ±0   3 💤 ±0  0 ❌ ±0 
1 808 runs  ±0  1 730 ✅ ±0  78 💤 ±0  0 ❌ ±0 

Results for commit ac65d7b. ± Comparison against base commit dda681a.

Copy link
Contributor

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against ac65d7b

Copy link
Contributor

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against ac65d7b

@sbrunato
Copy link
Collaborator

#1000 ! 🎂🥳

@sbrunato sbrunato merged commit 932eb17 into develop Jan 25, 2024
12 checks passed
@sbrunato sbrunato deleted the fix/dc-qs-date branch January 25, 2024 13:26
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants