Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): raise error if search fallback fails #1001

Merged
merged 3 commits into from Jan 19, 2024

Conversation

sbrunato
Copy link
Collaborator

@sbrunato sbrunato commented Jan 19, 2024

  • stores search errors in dag.search_errors during search fallback
  • raises an error in server mode if search fallback fails
  • raise_errors enabled when search by id

Copy link
Contributor

Test Results

    4 files  ±0      4 suites  ±0   4m 17s ⏱️ +3s
  453 tests +1    450 ✅ +1   3 💤 ±0  0 ❌ ±0 
1 812 runs  +4  1 734 ✅ +4  78 💤 ±0  0 ❌ ±0 

Results for commit a0f6258. ± Comparison against base commit dda681a.

Copy link
Contributor

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against a0f6258

Copy link
Contributor

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against a0f6258

@sbrunato sbrunato merged commit db70682 into develop Jan 19, 2024
12 checks passed
@sbrunato sbrunato deleted the search-errors-raise branch January 19, 2024 19:08
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant