Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse all product assets in the stac rest server json response #681

Merged
merged 4 commits into from May 5, 2023

Conversation

anesson-cs
Copy link
Collaborator

Fixes #346

The complete list of stac provider product assets (not only downloadLink and thumbnail) is parsed in the stac rest server json response.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

Test Results

       4 files  ±0         4 suites  ±0   4m 20s ⏱️ +34s
   388 tests +1     386 ✔️ +1    2 💤 ±0  0 ±0 
1 552 runs  +4  1 496 ✔️ +4  56 💤 ±0  0 ±0 

Results for commit d7ee7d7. ± Comparison against base commit bbd367a.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
tests.units.test_stac_utils.TestStacUtils ‑ test_search_stac_items
tests.units.test_stac_utils.TestStacUtils ‑ test_search_stac_items_with_non_stac_providers
tests.units.test_stac_utils.TestStacUtils ‑ test_search_stac_items_with_stac_providers

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

File Coverage
All files 89%
eodag/rest/stac.py 80%
tests/units/test_download_plugins.py 98%

File Coverage
All files 88%
eodag/rest/stac.py 80%
tests/units/test_download_plugins.py 98%
eodag/rest/stac.py 80%
tests/units/test_download_plugins.py 98%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 3c94009

@sbrunato sbrunato marked this pull request as draft March 29, 2023 09:39
@anesson-cs anesson-cs force-pushed the parse_json_response_in_stac_rest_server branch from f1dae37 to b553ebb Compare April 18, 2023 14:40
@sbrunato sbrunato force-pushed the parse_json_response_in_stac_rest_server branch from 3c94009 to d7ee7d7 Compare May 5, 2023 14:51
tests/units/test_download_plugins.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against d7ee7d7

@sbrunato sbrunato marked this pull request as ready for review May 5, 2023 14:56
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Code Coverage (Windows)

File Coverage
All files 77%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against d7ee7d7

@sbrunato sbrunato merged commit 2441b63 into develop May 5, 2023
12 checks passed
@sbrunato sbrunato deleted the parse_json_response_in_stac_rest_server branch May 5, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets are not parsed to the json response in the stac rest server
2 participants