Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search preferred provider and wekeo job error handling #790

Merged
merged 23 commits into from Aug 25, 2023

Conversation

jlahovnik
Copy link
Collaborator

@jlahovnik jlahovnik commented Aug 22, 2023

Contains the following changes:

  • The preferred provider is not changed anymore when a search or download is executed. If a provider is given in the request, it will be used (if it offers the selected product type) but the preferred provider is not changed. If no provider is given, the configured preferred provider is used.

Fixes #783

  • an error is raised when the creation of a data request job fails for wekeo

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

Test Results

       4 files  ±0         4 suites  ±0   6m 6s ⏱️ +26s
   404 tests +1     402 ✔️ +1    2 💤 ±0  0 ±0 
1 616 runs  +4  1 556 ✔️ +4  60 💤 ±0  0 ±0 

Results for commit 1a81749. ± Comparison against base commit 9acf017.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 1a81749

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 1a81749

Copy link
Collaborator

@sbrunato sbrunato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test to check the new behavior with preferred providers

eodag/plugins/search/data_request_search.py Outdated Show resolved Hide resolved
@sbrunato sbrunato changed the title Several fixes fix: search preferred provider and wekeo job error handling Aug 24, 2023
@sbrunato sbrunato merged commit 2eb52b8 into develop Aug 25, 2023
12 checks passed
@sbrunato sbrunato deleted the wekeo_fixes branch August 25, 2023 12:59
@sbrunato sbrunato added this to the 2.11.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[eodag-server] setting provider parameter in a request, default this provider as preferred for future requests
2 participants