Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 500 http error for server internal auth errors #794

Merged
merged 2 commits into from Aug 24, 2023

Conversation

sbrunato
Copy link
Collaborator

Send 500 http "Internal server error" to the client when capturing server side AuthenticationError

@github-actions
Copy link
Contributor

Test Results

       4 files  ±0         4 suites  ±0   5m 35s ⏱️ +10s
   403 tests ±0     401 ✔️ ±0    2 💤 ±0  0 ±0 
1 612 runs  ±0  1 552 ✔️ ±0  60 💤 ±0  0 ±0 

Results for commit dd37c9e. ± Comparison against base commit caff0bc.

@github-actions
Copy link
Contributor

Code Coverage (Ubuntu)

File Coverage
All files 81%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against dd37c9e

@github-actions
Copy link
Contributor

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against dd37c9e

@sbrunato sbrunato merged commit 62977ba into develop Aug 24, 2023
12 checks passed
@sbrunato sbrunato deleted the server_auth_errors branch August 24, 2023 16:02
@sbrunato sbrunato added this to the 2.11.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant