fix: authenticate only when performing search #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage (Ubuntu)
Minimum allowed coverage is Generated by 🐒 cobertura-action against f2d4356 |
|
Code Coverage (Windows)
Minimum allowed coverage is Generated by 🐒 cobertura-action against f2d4356 |
alambare-csgroup
force-pushed
the
prevent-auth-during-search-preparation
branch
8 times, most recently
from
2c6c535
to
3c29909
Compare
fix a bug that was sending authentication requests on each provider supported by the searched product type in the search request preparation
alambare-csgroup
force-pushed
the
prevent-auth-during-search-preparation
branch
from
3c29909
to
4ce70f6
Compare
sbrunato
force-pushed
the
prevent-auth-during-search-preparation
branch
from
6457521
to
f2d4356
Compare
sbrunato
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authenticate against the provider directly during the
_do_searchmethod. The_prepare_searchhas been refactored to not include anything related to authentication.Fix #801