Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return all available providers for collection #835

Conversation

jlahovnik
Copy link
Collaborator

@jlahovnik jlahovnik commented Sep 18, 2023

In server mode all available providers of a collection sorted by priority are now returned at the collections endpoint (GET /collections, GET /collections/id)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

Test Results

       4 files  ±  0         4 suites  ±0   6m 38s ⏱️ ±0s
   431 tests +11     428 ✔️ +11    3 💤 ±0  0 ±0 
1 724 runs  +44  1 648 ✔️ +40  76 💤 +4  0 ±0 

Results for commit 010a60d. ± Comparison against base commit d824947.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 010a60d

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 010a60d

Copy link
Collaborator

@sbrunato sbrunato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if provider is specified by the user, search fallback will be disabled. So in this case, we should not return the full list, but only this provider

@jlahovnik
Copy link
Collaborator Author

if provider is specified by the user, search fallback will be disabled. So in this case, we should not return the full list, but only this provider

changed

@sbrunato sbrunato merged commit a2506e6 into develop Oct 9, 2023
12 checks passed
@sbrunato sbrunato deleted the 834-add-to-server-collection-the-list-of-providers-for-which-it-is-supported branch October 9, 2023 15:36
@sbrunato sbrunato added this to the 2.11.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add to server collection the list of providers for which it is supported
2 participants