Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update open api static spec #846

Merged
merged 6 commits into from Nov 17, 2023
Merged

Conversation

bjgiraudon
Copy link
Collaborator

Description

This PR updates the openAPI static file located at ./eodag/resources/stac_api.yml, updating the description and summaries of endpoints as well as adding a query entry in the list of parameters.

It fixes the issue #839

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Test Results

       4 files  ±0         4 suites  ±0   3m 29s ⏱️ -2s
   430 tests ±0     427 ✔️ ±0    3 💤 ±0  0 ±0 
1 720 runs  ±0  1 644 ✔️ ±0  76 💤 ±0  0 ±0 

Results for commit 7e46328. ± Comparison against base commit 09a9b79.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 7e46328

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 7e46328

@bjgiraudon bjgiraudon force-pushed the 839-improve-openapi-doc branch 2 times, most recently from a9ab5d4 to 0e66de3 Compare October 2, 2023 13:37
@sbrunato sbrunato linked an issue Oct 2, 2023 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@sbrunato sbrunato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed changes:

  • /api : example to {}
  • /queryables: adapt description (no CQL2)
  • /collections: remove parameters
  • /collections/{collectionId}/queryables: adapt description (no CQL2)
  • /catalogs/{catalogPath}/items/{featureId}/download: remove "string" for 200 example value
  • add /catalogs/{catalogPath}/items
  • *: change 404 example
  • *: add 400 code in responses
  • *: change 500 response example format

@bjgiraudon bjgiraudon force-pushed the 839-improve-openapi-doc branch 4 times, most recently from c017233 to e290527 Compare October 10, 2023 14:45
Copy link
Collaborator

@sbrunato sbrunato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe more the query extension usage and adapt to our implementation (see #839 description). Details for accepted operators and parameters can be found in rest.utils.get_criterias_from_metadata_mapping() that uses conf from resources/stac_provider.yml

@bjgiraudon bjgiraudon force-pushed the 839-improve-openapi-doc branch 4 times, most recently from 9ab05c3 to 8dcf05b Compare October 17, 2023 08:54
Copy link
Collaborator

@sbrunato sbrunato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • put working examples that users can directly execute (no "string" values)

eodag/resources/stac_api.yml Outdated Show resolved Hide resolved
eodag/resources/stac_api.yml Outdated Show resolved Hide resolved
eodag/resources/stac_api.yml Outdated Show resolved Hide resolved
eodag/resources/stac_api.yml Outdated Show resolved Hide resolved
eodag/resources/stac_api.yml Outdated Show resolved Hide resolved
eodag/resources/stac_api.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@sbrunato sbrunato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please restore previous server methods sorting, as some are not working any more (/catalogs/{catalogs}/items/{item_id}/download interpreted as /catalogs/{catalogs})
  • /collections/{collection_id}/items/{item_id} and /collections/{collection_id}/items/{item_id}/download forms are opening together when you click on one of them ...
  • remove query from GET /search
  • give a working example in POST /search
  • give more details on searchBody in POST /search (display its description or at least a link to it)

@sbrunato sbrunato merged commit ec1d847 into develop Nov 17, 2023
12 checks passed
@sbrunato sbrunato deleted the 839-improve-openapi-doc branch November 17, 2023 14:23
@sbrunato sbrunato added this to the 2.11.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better document server mode interfaces
2 participants