fix: return only user requested DataRequestSearch item if id is present #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage (Ubuntu)
Minimum allowed coverage is Generated by 🐒 cobertura-action against f9a5bdb |
|
Code Coverage (Windows)
Minimum allowed coverage is Generated by 🐒 cobertura-action against f9a5bdb |
sbrunato
changed the title
sbrunato
requested changes
Oct 5, 2023
Comment on lines
320
to
326
| # postprocess filtering needed when provider does not natively offer | ||
| # filtering by id | ||
| if "id" in kwargs: | ||
| results = [ | ||
| r for r in results if r["productInfo"]["product"] == kwargs["id"] | ||
| ] or results | ||
|
|
There was a problem hiding this comment.
these test & filtering should be done after normalizing by checking products[].properties["id"]
alambare-csgroup
force-pushed
the
fix-wekeo-single-id
branch
from
fcb5f7d
to
f9a5bdb
Compare
sbrunato
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the single requested item if the requested item id is found in the results.