Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add some type hint #880

Merged
merged 24 commits into from Dec 5, 2023
Merged

refactor: add some type hint #880

merged 24 commits into from Dec 5, 2023

Conversation

alambare-csgroup
Copy link
Collaborator

@alambare-csgroup alambare-csgroup commented Oct 12, 2023

Add type hint

Move DownloadedCallback from eodag/utils to eodag/api/product to avoid circular import
Move some env vars to utils

related to #863

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Test Results

       4 files  ±0         4 suites  ±0   3m 24s ⏱️ -1s
   433 tests ±0     430 ✔️ ±0    3 💤 ±0  0 ±0 
1 732 runs  ±0  1 656 ✔️ ±0  76 💤 ±0  0 ±0 

Results for commit cfaaaa8. ± Comparison against base commit 1631c88.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against cfaaaa8

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against cfaaaa8

@alambare-csgroup alambare-csgroup changed the title some type hint for utils.py refactor: add type hint for utils.py Oct 13, 2023
@alambare-csgroup alambare-csgroup changed the title refactor: add type hint for utils.py refactor: add some type hint Oct 13, 2023
@alambare-csgroup alambare-csgroup force-pushed the some-type-hint branch 5 times, most recently from dd3a827 to f1bb2bc Compare October 13, 2023 12:58
@alambare-csgroup alambare-csgroup self-assigned this Oct 13, 2023
@alambare-csgroup alambare-csgroup marked this pull request as draft October 18, 2023 14:25
@alambare-csgroup
Copy link
Collaborator Author

Those commits require that we remove the support for python3.7 prior merging

@alambare-csgroup alambare-csgroup marked this pull request as ready for review October 23, 2023 09:05
@alambare-csgroup alambare-csgroup force-pushed the some-type-hint branch 3 times, most recently from f007a84 to 1a89aa9 Compare November 16, 2023 17:19
@alambare-csgroup alambare-csgroup removed the request for review from sbrunato November 17, 2023 13:36
@alambare-csgroup alambare-csgroup marked this pull request as draft November 17, 2023 13:37
@alambare-csgroup alambare-csgroup marked this pull request as ready for review November 21, 2023 11:28
@sbrunato sbrunato merged commit a6be03b into develop Dec 5, 2023
12 checks passed
@sbrunato sbrunato deleted the some-type-hint branch December 5, 2023 09:07
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants