Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: product type alias #905

Merged
merged 9 commits into from Dec 7, 2023
Merged

feat: product type alias #905

merged 9 commits into from Dec 7, 2023

Conversation

jlahovnik
Copy link
Collaborator

  • aliases can be defined for a product type in the product_types.yml
  • this alias will then be shown instead of the id in request responses
  • the alias can also be used to search for products and to fetch collection information

@jlahovnik jlahovnik self-assigned this Oct 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

Test Results

       4 files  ±  0         4 suites  ±0   3m 26s ⏱️ ±0s
   439 tests +  3     436 ✔️ +  3    3 💤 ±0  0 ±0 
1 756 runs  +12  1 680 ✔️ +12  76 💤 ±0  0 ±0 

Results for commit f854230. ± Comparison against base commit 17244d7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against f854230

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against f854230

@alambare-csgroup alambare-csgroup linked an issue Nov 17, 2023 that may be closed by this pull request
@sbrunato sbrunato changed the title Feature/product type alias feat: product type alias Dec 7, 2023
@sbrunato sbrunato merged commit b61e2a0 into develop Dec 7, 2023
12 checks passed
@sbrunato sbrunato deleted the feature/product-type-alias branch December 7, 2023 10:47
alambare-csgroup pushed a commit that referenced this pull request Dec 12, 2023
Co-authored-by: leso-kn <info@lesosoftware.com>
Co-authored-by: Sylvain Brunato <sylvain.brunato@c-s.fr>
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

product types aliases
3 participants