Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin manager rebuild #919

Merged
merged 1 commit into from Nov 14, 2023
Merged

fix: plugin manager rebuild #919

merged 1 commit into from Nov 14, 2023

Conversation

sbrunato
Copy link
Collaborator

Adds a new method PluginManager.rebuild() to avoid creating a new manager when only rebuild is needed, and prevent issues with providers settings and priorities.

Fixes #567

Copy link
Contributor

Test Results

       4 files  +       2         4 suites  +2   3m 44s ⏱️ + 1m 41s
   430 tests ±       0     427 ✔️ +       1    3 💤 ±  0  0  - 1 
1 720 runs  +1 169  1 644 ✔️ +1 097  76 💤 +73  0  - 1 

Results for commit d5773c4. ± Comparison against base commit f323366.

Copy link
Contributor

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against d5773c4

Copy link
Contributor

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against d5773c4

@sbrunato sbrunato merged commit 1d9f92c into develop Nov 14, 2023
12 checks passed
@sbrunato sbrunato deleted the plugin-manager-rebuild branch November 14, 2023 08:43
@sbrunato sbrunato added this to the 2.11.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting Custom provider as preferred doesn't work
1 participant