Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): CdsApi download using _dc_qs parameter #958

Merged
merged 2 commits into from Dec 8, 2023

Conversation

sbrunato
Copy link
Collaborator

@sbrunato sbrunato commented Dec 8, 2023

Fixes server mode CdsApi dowloads using a new parameter _dc_qs to store query parameters

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Test Results

       4 files  ±0         4 suites  ±0   3m 28s ⏱️ -1s
   439 tests ±0     436 ✔️ ±0    3 💤 ±0  0 ±0 
1 756 runs  ±0  1 680 ✔️ ±0  76 💤 ±0  0 ±0 

Results for commit c353931. ± Comparison against base commit 300a2f8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against c353931

Copy link
Contributor

github-actions bot commented Dec 8, 2023

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against c353931

@sbrunato sbrunato merged commit 1af3d19 into develop Dec 8, 2023
12 checks passed
@sbrunato sbrunato deleted the server-mode-cds-download branch December 8, 2023 15:47
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant