Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cast loaded env vars type using config type-hints #987

Merged
merged 3 commits into from Jan 15, 2024

Conversation

sbrunato
Copy link
Collaborator

Fixes #985 and #973

  • Cast loaded environment variables type using PluginConfig parameters type-hints.
  • also adds some more type hint fixes

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Test Results

    4 files  ±0      4 suites  ±0   4m 8s ⏱️ ±0s
  449 tests +1    446 ✅ +1   3 💤 ±0  0 ❌ ±0 
1 796 runs  +4  1 718 ✅ +4  78 💤 ±0  0 ❌ ±0 

Results for commit 4256824. ± Comparison against base commit fe2a514.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 15, 2024

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 4256824

Copy link
Contributor

github-actions bot commented Jan 15, 2024

Code Coverage (Windows)

File Coverage
All files 76%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 4256824

@sbrunato sbrunato merged commit 270f673 into develop Jan 15, 2024
12 checks passed
@sbrunato sbrunato deleted the env_vars_typing branch January 15, 2024 16:06
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert timeout type when loaded from environment variable
1 participant