Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): delete file after download without streaming #992

Merged
merged 1 commit into from Jan 17, 2024
Merged

fix(server): delete file after download without streaming #992

merged 1 commit into from Jan 17, 2024

Conversation

sbrunato
Copy link
Collaborator

Fixes server-mode error when trying to delete local data after a download and streaming not available

@github-actions GitHub Actions
Copy link
Contributor

Test Results

    4 files  ±0      4 suites  ±0   4m 7s ⏱️ -4s
  449 tests ±0    446 ✅ ±0   3 💤 ±0  0 ❌ ±0 
1 796 runs  ±0  1 718 ✅ ±0  78 💤 ±0  0 ❌ ±0 

Results for commit ad4720c. ± Comparison against base commit 270f673.

@github-actions GitHub Actions
Copy link
Contributor

Code Coverage (Ubuntu)

File Coverage
All files 82% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against ad4720c

@github-actions GitHub Actions
Copy link
Contributor

Code Coverage (Windows)

File Coverage
All files 76% ✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against ad4720c

@sbrunato sbrunato merged commit 819247c into develop Jan 17, 2024
12 checks passed
@sbrunato sbrunato deleted the server-download-nostream branch January 17, 2024 08:05
@sbrunato sbrunato added this to the 2.12.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sbrunato