Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE Dry Run]Add loan command does not tell invalid parameter #204

Closed
nus-se-bot opened this issue Nov 3, 2018 · 1 comment
Closed

[PE Dry Run]Add loan command does not tell invalid parameter #204

nus-se-bot opened this issue Nov 3, 2018 · 1 comment
Assignees
Labels
Documentation Documentation for repo priority.Low Unlikely to do wontfix This will not be worked on

Comments

@nus-se-bot
Copy link

When trying to add a new loan for a bike, in case of invalid parameter, the error message displayed does not inform which parameter is invalid or entered wrongly.

image
Invalid name? or wrong usage of "p/" or "n/"?

image
Invalid NRIC?

image
Unsure what is the invalid parameter here....


Reported by: @yogtew
Severity: High

[original: nus-cs2103-AY1819S1/pe-dry-run#394]

@OrangeJuice7
Copy link
Collaborator

Thank you for reporting this.

The app reports that the command format is invalid because you did not specify all the parameters required by the command. The prefix for the loan rate parameter is lr/, not r/, thus the app did not recognize that as a valid parameter and thus valid command format.

Once all the required parameter prefixes are present and correct, the app will then check for the validity of the individual parameters and give specific feedback. We will note this in the UG for future versions. Thank you very much!

@OrangeJuice7 OrangeJuice7 added Documentation Documentation for repo and removed Valid Issue This issue is an ongoing issue. labels Nov 4, 2018
@prokarius prokarius added wontfix This will not be worked on priority.Low Unlikely to do and removed priority.High Must do labels Nov 9, 2018
@wn wn closed this as completed Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation for repo priority.Low Unlikely to do wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants