Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added XmlAdaptedGroup and XmlAdaptedGroupTest classes #112

Merged
merged 4 commits into from Oct 21, 2018
Merged

Added XmlAdaptedGroup and XmlAdaptedGroupTest classes #112

merged 4 commits into from Oct 21, 2018

Conversation

Derek-Hardy
Copy link

No description provided.

@Derek-Hardy Derek-Hardy added this to the v1.3 milestone Oct 21, 2018
@Derek-Hardy Derek-Hardy self-assigned this Oct 21, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 192

  • 47 of 47 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 91.127%
Totals Coverage Status
Change from base Build 191: 0.2%
Covered Lines: 2167
Relevant Lines: 2378
💛 - Coveralls

jeffreyooi
jeffreyooi approved these changes Oct 21, 2018
View reviewed changes
Copy link

@jeffreyooi jeffreyooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeffreyooi jeffreyooi merged commit 2d07d60 into CS2103-AY1819S1-W17-3:master Oct 21, 2018
@Derek-Hardy Derek-Hardy removed the request for review from Zenious October 21, 2018 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffreyooi jeffreyooi jeffreyooi approved these changes

Assignees

@Derek-Hardy Derek-Hardy

Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Derek-Hardy @coveralls @jeffreyooi